[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101914#comment-17101914 ]
Roger Lee Whitcomb commented on PIVOT-1032: ------------------------------------------- Some more updates to the style summary: Sending StyleErrors.java Sending build.xml Transmitting file data ..done Committing transaction... Committed revision 1877481. Producing another report section: {code} [echo] Files with the most errors: [echo] TerraTreeViewSkin.java 493 [echo] TerraTabPaneSkin.java 350 [echo] Component.java 334 [echo] TerraVFSBrowserSkin.java 303 [echo] KitchenSink.java 300 [echo] TerraScrollBarSkin.java 284 [echo] TerraFileBrowserSkin.java 272 [echo] TerraAccordionSkin.java 255 [echo] EnumBean.java 255 [echo] TerraFormSkin.java 246 [echo] TerraCalendarSkin.java 241 [echo] TerraTableViewHeaderSkin.java 240 [echo] [echo] Files with the fewest errors: [echo] CharUtils.java 1 [echo] TableViewBooleanCellRenderer.java 1 [echo] StyleErrors.java 1 [echo] VerticalButtonDataRenderer.java 1 [echo] MeterView.java 1 [echo] CurrencyValidator.java 1 [echo] PieChartView.java 1 [echo] TableViewTriStateCellRenderer.java 1 [echo] SampleBean2Map.java 1 [echo] PropertyChangeListener.java 1 [echo] IDProperty.java 1 [echo] Command.java 1 {code} > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --------------------------------------------------------------------------------------- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement > Reporter: Roger Lee Whitcomb > Assignee: Roger Lee Whitcomb > Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian Jira (v8.3.4#803005)