[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102811#comment-17102811 ]
Roger Lee Whitcomb commented on PIVOT-1032: ------------------------------------------- FIx a number of the files with only one or two errors: Sending charts/src/org/apache/pivot/charts/AreaChartView.java Sending charts/src/org/apache/pivot/charts/BarChartView.java Sending charts/src/org/apache/pivot/charts/HighLowChartView.java Sending charts/src/org/apache/pivot/charts/LineChartView.java Sending charts/src/org/apache/pivot/charts/MeterView.java Sending charts/src/org/apache/pivot/charts/PieChartView.java Sending charts/src/org/apache/pivot/charts/ProviderNotFoundException.java Sending charts/src/org/apache/pivot/charts/content/ValueSeries.java Sending core/src/org/apache/pivot/beans/BXML.java Sending core/src/org/apache/pivot/beans/Bindable.java Sending core/src/org/apache/pivot/beans/DefaultProperty.java Sending core/src/org/apache/pivot/beans/IDProperty.java Sending core/src/org/apache/pivot/beans/PropertyChangeListener.java Sending core/src/org/apache/pivot/functional/functions/Procedure0.java Sending core/src/org/apache/pivot/serialization/CSVSerializerListener.java Sending core/src/org/apache/pivot/text/FileSizeFormat.java Sending core/src/org/apache/pivot/util/Command.java Sending core/src/org/apache/pivot/util/Filter.java Sending core/src/org/apache/pivot/util/ImmutableIterator.java Sending core/src/org/apache/pivot/util/TypeLiteral.java Sending core/src/org/apache/pivot/util/Vote.java Sending core/src/org/apache/pivot/util/VoteResult.java Sending core/test/org/apache/pivot/json/test/SampleBean2DictionarySubclass.java Sending core/test/org/apache/pivot/json/test/SampleBean2List.java Sending core/test/org/apache/pivot/json/test/SampleBean2ListSubclass.java Sending core/test/org/apache/pivot/json/test/SampleBean2Map.java Sending core/test/org/apache/pivot/json/test/SampleBean2MapSubclass.java Sending core/test/org/apache/pivot/json/test/SampleBean2SequenceSubclass.java Sending core/test/org/apache/pivot/serialization/test/StringSerializerTest.java Sending demos/src/org/apache/pivot/demos/roweditor/CurrencyValidator.java Sending tutorials/src/org/apache/pivot/tutorials/webqueries/AmountValidator.java Sending wtk/src/org/apache/pivot/wtk/FlowPane.java Sending wtk/src/org/apache/pivot/wtk/Orientation.java Sending wtk/src/org/apache/pivot/wtk/Panel.java Sending wtk/src/org/apache/pivot/wtk/Renderer.java Sending wtk/src/org/apache/pivot/wtk/StackPane.java Sending wtk/src/org/apache/pivot/wtk/TextDecoration.java Sending wtk/src/org/apache/pivot/wtk/WTKListenerList.java Sending wtk/src/org/apache/pivot/wtk/content/AccordionHeaderDataRenderer.java Sending wtk/src/org/apache/pivot/wtk/content/TableViewBooleanCellRenderer.java Sending wtk/src/org/apache/pivot/wtk/content/TableViewTriStateCellRenderer.java Sending wtk/src/org/apache/pivot/wtk/content/VerticalButtonDataRenderer.java Sending wtk/src/org/apache/pivot/wtk/effects/TransitionListener.java Sending wtk/src/org/apache/pivot/wtk/skin/SliderSkin.java Transmitting file data ............................................done Committing transaction... Committed revision 1877519. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --------------------------------------------------------------------------------------- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement > Reporter: Roger Lee Whitcomb > Assignee: Roger Lee Whitcomb > Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian Jira (v8.3.4#803005)