spnettec commented on code in PR #818: URL: https://github.com/apache/plc4x/pull/818#discussion_r1114494692
########## plc4j/tools/connection-cache/src/main/java/org/apache/plc4x/java/utils/cache/CachedPlcConnectionManager.java: ########## @@ -81,14 +93,16 @@ public PlcConnection getConnection(String url) throws PlcConnectionException { try { return leaseFuture.get(this.maxWaitTime.toMillis(), TimeUnit.MILLISECONDS); } catch (ExecutionException | InterruptedException | TimeoutException e) { + connectionContainer.close(); + connectionContainers.remove(url); throw new PlcConnectionException("Error acquiring lease for connection", e); } } - public PlcConnection getConnection(String url, PlcAuthentication authentication) throws PlcConnectionException { - throw new PlcConnectionException("the cached driver manager currently doesn't support authentication"); Review Comment: Just leave it for the future to authorize -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org