hongjinlin commented on code in PR #818:
URL: https://github.com/apache/plc4x/pull/818#discussion_r1115166844
##########
plc4j/tools/connection-cache/src/main/java/org/apache/plc4x/java/utils/cache/LeasedPlcConnection.java:
##########
@@ -66,7 +76,7 @@ public void connect() throws PlcConnectionException {
@Override
public boolean isConnected() {
if(connection == null) {
- throw new PlcRuntimeException("Error using leased connection after
returning it to the cache.");
+ return false;
Review Comment:
> I have already explained that previous PR are the basis for subsequent
PRs. Next I want to submit a PR for PL4x
First of all, thank you for your PR. Secondly, I think it would be
beneficial if you could discuss your entire design approach with everyone,
rather than just submitting a basic PR and following up with subsequent PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
