spnettec commented on code in PR #818: URL: https://github.com/apache/plc4x/pull/818#discussion_r1114527206
########## plc4j/spi/src/main/java/org/apache/plc4x/java/spi/messages/DefaultPlcWriteRequest.java: ########## @@ -194,6 +196,9 @@ public PlcWriteRequest build() { PlcTag tag = tagValues.getLeft().get(); Object[] value = tagValues.getRight(); PlcValue plcValue = valueHandler.newPlcValue(tag, value); + if(tag.getPlcValueType()== PlcValueType.NULL){ Review Comment: By the way. The value can be set null not PlcValueType be set NULL. PLC4x driver write request must give explicit data type. This limits all the driver write tag format for the PLC4x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org