hongjinlin commented on code in PR #818:
URL: https://github.com/apache/plc4x/pull/818#discussion_r1115163118


##########
plc4j/tools/connection-cache/src/main/java/org/apache/plc4x/java/utils/cache/LeasedPlcConnection.java:
##########
@@ -66,7 +76,7 @@ public void connect() throws PlcConnectionException {
     @Override
     public boolean isConnected() {
         if(connection == null) {
-            throw new PlcRuntimeException("Error using leased connection after 
returning it to the cache.");
+            return false;

Review Comment:
   > 
   
   
   
   > 
   
   I have encountered a scenario where the PLC connection appeared to be 
disconnected, but in reality it was still connected due to certain reasons. 
However, we kept trying to reconnect and as a result, the TCP estab value 
increased to tens of thousands. This caused the PLC to be disconnected and also 
resulted in server network issues. Therefore, I'm looking to see if there is a 
better solution available.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to