sruehl commented on code in PR #1468:
URL: https://github.com/apache/plc4x/pull/1468#discussion_r1572300903
##########
plc4j/drivers/mock/src/main/java/org/apache/plc4x/java/mock/connection/MockConnection.java:
##########
@@ -221,4 +224,14 @@ public PlcAuthentication getAuthentication() {
return authentication;
}
+ @Override
+ public Optional<PlcTag> parseTagAddress(String tagAddress) {
+ PlcTag plcTag;
+ try{
+ plcTag = mockTagHandler.parseTag(tagAddress);
+ }catch (Exception e){
Review Comment:
the Exception should be at least logged at a debug level or if it never
matters the variable should be renamed to `ignore`
##########
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/connection/AbstractPlcConnection.java:
##########
@@ -228,4 +230,14 @@ public CompletableFuture<PlcBrowseResponse>
browseWithInterceptor(PlcBrowseReque
return protocol.browseWithInterceptor(browseRequest, interceptor);
}
+ @Override
+ public Optional<PlcTag> parseTagAddress(String tagAddress) {
+ PlcTag plcTag;
+ try{
+ plcTag = tagHandler.parseTag(tagAddress);
+ }catch (Exception e){
Review Comment:
the Exception should be at least logged at a debug level or if it never
matters the variable should be renamed to `ignore`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
