chrisdutz commented on code in PR #1468:
URL: https://github.com/apache/plc4x/pull/1468#discussion_r1574560265
##########
plc4j/tools/connection-cache/src/main/java/org/apache/plc4x/java/utils/cache/LeasedPlcConnection.java:
##########
@@ -80,6 +80,11 @@ public synchronized void close() {
connectionContainer.returnConnection(this, invalidateConnection);
}
+ @Override
+ public Optional<PlcTag> parseTagAddress(String tagAddress) {
+ return Optional.empty();
Review Comment:
Leased connection has a "connection" property which refers to the actual
connection ... so I guess something like this should work:
```
@Override
public Optional<PlcTag> parseTagAddress(String tagAddress) {
PlcConnection plcConnection = connection.get();
if(plcConnection == null) {
throw new PlcRuntimeException("Error using leased connection
after returning it to the cache.");
}
return plcConnection.parseTagAddress(tagAddress);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
