qtvbwfn commented on code in PR #1468:
URL: https://github.com/apache/plc4x/pull/1468#discussion_r1574462412
##########
plc4j/tools/connection-cache/src/main/java/org/apache/plc4x/java/utils/cache/LeasedPlcConnection.java:
##########
@@ -80,6 +80,11 @@ public synchronized void close() {
connectionContainer.returnConnection(this, invalidateConnection);
}
+ @Override
+ public Optional<PlcTag> parseTagAddress(String tagAddress) {
+ return Optional.empty();
Review Comment:
> I think this should probably forward to the driver being used and not
simply return empty.
Requesting assistance, as I am not very familiar with the overall code of
the project, PlcTagHandler was not found within LeasedPlcConnection. However,
LeasedPlcConnection is an implementation class of PlcConnection. Is it
appropriate to directly use connection.get().parseTagAddress(tagAddress)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
