chrisdutz commented on PR #1468: URL: https://github.com/apache/plc4x/pull/1468#issuecomment-2068913799
Hmmm ... so we now have a parseTag on Driver and Connection ... I'm thinking it might be better to give the driver-version a slightly different name. The parse method there can technically only parse on a much higher level. The version on the connection-level knows the type of device and can offer a more-correct answer. But generally this PR looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
