[
https://issues.apache.org/jira/browse/QPIDJMS-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957477#comment-16957477
]
ASF GitHub Bot commented on QPIDJMS-441:
----------------------------------------
tabish121 commented on issue #32: QPIDJMS-441: add proxy support
URL: https://github.com/apache/qpid-jms/pull/32#issuecomment-545219267
I'm not sure I agree with the testing methodology of just picking a few
random tests and duplicating the entire test case. It adds a bunch of time to
the unit test run(a full minute on my machine) but I'm not sure it actually
narrowly targets the changes that have been made in a manner that actually
proves the changes are sound for the various bits that really matter like
failover which should be testing that new proxy handlers are swapped in for
different URIs etc. Also it doesn't seem to hit cases of the proxy itself
being down or malfunctioning. I saw that Netty has a suite of tests that can
simulate different error failures of the proxy itself which might be a good
thing to emulate.
I'd rather see something like a ProxiedConnectionTest that covers the
aspects of using the proxy where things go wrong and we ensure that they are
handled. Otherwise just running some already written tests with the proxy
thrown in doesn't really test the edges.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Using QPID JMS behind a proxy
> -----------------------------
>
> Key: QPIDJMS-441
> URL: https://issues.apache.org/jira/browse/QPIDJMS-441
> Project: Qpid JMS
> Issue Type: Wish
> Components: qpid-jms-client
> Affects Versions: 0.40.0
> Reporter: morten
> Priority: Blocker
>
> I actually did not find a possibility to use the jms qpid client behind a
> proxy. I guess there will be a lot of people who needs to run the library
> behind a proxy. It would be nice to have the possibility to set a proxy
> somehow.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
