[
https://issues.apache.org/jira/browse/QPIDJMS-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957831#comment-16957831
]
ASF GitHub Bot commented on QPIDJMS-441:
----------------------------------------
gemmellr commented on issue #32: QPIDJMS-441: add proxy support
URL: https://github.com/apache/qpid-jms/pull/32#issuecomment-545417119
I understand a lot of its the same, thats why we are not expecting to see
swathes of tests duplicated but rather simple test coverage only for the new
functionality being added with its own specific wiring needing exercised.
As I've noted for me basic and key situations would be exercising creating
an actual connection over the proxy, then again with SSL/TLS, for each proxy
type, plus verifying the proxying stuff works at all with failover connections
and e.g that the supplier gets called for each connect+reconnect.
I don't think anyone is expecting you to know all of the codebase or inspect
all 3000 the tests, that's why we've touched on specific classes and locations
etc until now. I have not had a specific set of tests in mind to duplicate
because I've not been looking to simply do that. Obviously I'd expect you to
draw from some of the existing tests though, many of which were already
specifically touched on or you've modified already. A lot of these are not
mysterious, e.g, look at the names or even the first test in many cases, or
grep for the URL scheme.
For example, ConnectionIntegrationTest.testCreateAndCloseConnection()
creates and closes a connection. Something similar to that, which connected
through a Socks proxy, gives us some indication that there is proxy handling
functionality occurring and helps ensure it continues to. Similarly with
SSL/TLS, e.g see SslIntegrationTest.testCreateAndCloseSslConnectionJDK(). For
failover, essentially any test that actually performs a failover would likely
provide appropriate inspiration, e.g
FailoverIntegrationTest.testCreateConsumerAfterConnectionDrops(). A variant of
that using a proxy helps assure it works with failover, and e.g could also
verify how many times the handler supplier is used. For Websockets and HTTP
proxy, you could give JmsWSConnectionTest and JmsWSSConnectionTest a look in
the activemq tests module. Obviously that being its own module would mean
either moving the proxy there and forgoing the transport test, or duplicating
the proxy, personally I'd be fine with either of those approaches personally.
Finally, updating the existing TransportOptionsTest tests to cover the new
options field added to the TransportOptions class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Using QPID JMS behind a proxy
> -----------------------------
>
> Key: QPIDJMS-441
> URL: https://issues.apache.org/jira/browse/QPIDJMS-441
> Project: Qpid JMS
> Issue Type: Wish
> Components: qpid-jms-client
> Affects Versions: 0.40.0
> Reporter: morten
> Priority: Blocker
>
> I actually did not find a possibility to use the jms qpid client behind a
> proxy. I guess there will be a lot of people who needs to run the library
> behind a proxy. It would be nice to have the possibility to set a proxy
> somehow.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
