[
https://issues.apache.org/jira/browse/QPIDJMS-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962304#comment-16962304
]
ASF GitHub Bot commented on QPIDJMS-441:
----------------------------------------
gemmellr commented on issue #32: QPIDJMS-441: add proxy support
URL: https://github.com/apache/qpid-jms/pull/32#issuecomment-547565314
Tim and I took a look at this latest version and made some fixes and tweaks,
you can see the current state of them in the second commit at:
https://github.com/apache/qpid-jms/compare/master...gemmellr:pr32-proxy-b
There is still a remaining issue needing resolved before the addition can be
made however. The failover test (\[1\]) failed very occasionally for me when
run locally, and fails a lot of the time when run in the Appveyor CI job on
Windows. After some digging we eventually established this seems to happen when
the proxy doesnt look to close the connection from the client, after the test
peer drops the server end. The client thus doesn't notice the drop as intended
in the test, which eventually times out waiting for the failover and subsequent
test steps to happen.
This seems to happen only when the proxy code goes through this segment:
https://github.com/apache/qpid-jms/commit/436092b2eba9a4b46a7b5ed404e60e3803d0f141#diff-a85fa6452826ab6e749d0c34973365f1R310
of the read processing. However, just adding a matching close for the
writeChannel there makes the test (and others) fail differently, doing the
expected steps but throwing during autoclosure of the test peer because its
final read attempt had thrown a connection reset exception. Its not immediately
clear to me why that happens, but the test issues need resolved one way or
another before this can be merged so it would be good if you could debug it to
resolve it.
If you identify a fix, just add a new commit on top of those ones so we can
easily see the new changes. You can enable Appveyor (https://ci.appveyor.com)
on your fork of the repo and it will pick up the existing configuration in
there and run when you push changes, plus you can repeat builds through the
Appveyor site. The Repeat annotation (\[2\]) above the test can be be useful
for running lots of iterations of a test in a single test run while verifying
changes.
(\[1\])
https://github.com/apache/qpid-jms/commit/436092b2eba9a4b46a7b5ed404e60e3803d0f141#diff-eab37a02742dcdeacb54fd8fde6e5a6bR133
(\[2\])
https://github.com/apache/qpid-jms/commit/436092b2eba9a4b46a7b5ed404e60e3803d0f141#diff-eab37a02742dcdeacb54fd8fde6e5a6bR131
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Using QPID JMS behind a proxy
> -----------------------------
>
> Key: QPIDJMS-441
> URL: https://issues.apache.org/jira/browse/QPIDJMS-441
> Project: Qpid JMS
> Issue Type: Wish
> Components: qpid-jms-client
> Affects Versions: 0.40.0
> Reporter: morten
> Priority: Blocker
>
> I actually did not find a possibility to use the jms qpid client behind a
> proxy. I guess there will be a lot of people who needs to run the library
> behind a proxy. It would be nice to have the possibility to set a proxy
> somehow.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
