Hi Kohei, I commented on it, I'm not sure Dave needs to do a new build
just for this issue, your older patch fixed 90% of the problem and it's
not that much for someone having a problem with the other 10% to make a
manual change to their database to fix the issue. For a more permanent
solution, I might recommend just changing the database widths from 2 to
3 in our createdb script (i.e., just keep the JIRA item open for now) so
brand new users are fine but not bother creating 5.1.1->5.1.2 migration
scripts for something as minimal as that. For the half-dozen who might
bark at us we can tell them to just manually make the width change in
their own databases.
Unless Dave is certain he wants to create a new RC, I plan on testing
the current one and approving it if it works for me.
Glen
On 03/01/2015 08:04 PM, Kohei Nozaki wrote:
Sorry I just found a problem to my patch which accepted in
https://issues.apache.org/jira/browse/ROL-2063 . could you take a look at my
new patch ROL-2063_update1.patch and comment in that JIRA?
ROL-2063_update1.patch
On Mar 2, 2015, at 4:56, Dave <[email protected]> wrote:
Hi Roller fans,
I would like to propose that we release Roller 5.1.2 based on the code at
Subversion tag roller_5.1.2-rc1. You can download the source release,
convenience binaries and signatures for the release here:
https://dist.apache.org/repos/dist/dev/roller/roller-5.1/v5.1.2/
The release contains a variety of mostly minor fixes which you can find
listed here:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20ROL%20AND%20fixVersion%20%3D%205.1.2%20AND%20updated%20%3E%3D%20-20w%20ORDER%20BY%20updated%20DESC
Please vote within the next 72 hours.
I'm voting +1
Thanks,
Dave
