----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17875/#review34384 -----------------------------------------------------------
samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala <https://reviews.apache.org/r/17875/#comment64465> Looks like we're still losing SAMZA096 with this patch. Make sure you've merged in the latest changes from trunk. samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala <https://reviews.apache.org/r/17875/#comment64504> Part of the thread renaming loss samza-kafka/src/main/scala/org/apache/samza/util/ExponentialThreadSleepStrategy.scala <https://reviews.apache.org/r/17875/#comment64505> Need ASF file header samza-kafka/src/main/scala/org/apache/samza/util/ExponentialThreadSleepStrategy.scala <https://reviews.apache.org/r/17875/#comment64466> These can be vals since they are constants. samza-kafka/src/main/scala/org/apache/samza/util/ExponentialThreadSleepStrategy.scala <https://reviews.apache.org/r/17875/#comment64467> in the class, import ExpotentialThreadSleepStrategy._ and we can avoid all the extra qualification, to aid in readability. samza-kafka/src/main/scala/org/apache/samza/util/ExponentialThreadSleepStrategy.scala <https://reviews.apache.org/r/17875/#comment64510> Since the class has been broken out and can be used for more than just redelivery delays, can we make this a more generic name to ease re-use? samza-kafka/src/test/scala/org/apache/samza/util/TestExponentialThreadSleepStrategy.scala <https://reviews.apache.org/r/17875/#comment64506> Need ASF file header samza-kafka/src/test/scala/org/apache/samza/util/TestExponentialThreadSleepStrategy.scala <https://reviews.apache.org/r/17875/#comment64508> Not logging so don't need to extend. samza-kafka/src/test/scala/org/apache/samza/util/TestExponentialThreadSleepStrategy.scala <https://reviews.apache.org/r/17875/#comment64509> Can we extend the test to make sure we don't go past the maximum allowed? ie, we never go above 10000 ms? - Jakob Homan On Feb. 11, 2014, 7:33 p.m., Steven Yates wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17875/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2014, 7:33 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > SAMZA-30 - Back off in BrokerProxy when fetch fails > > > Diffs > ----- > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala > 95a1fb5 > > samza-kafka/src/main/scala/org/apache/samza/util/ExponentialThreadSleepStrategy.scala > PRE-CREATION > > samza-kafka/src/test/scala/org/apache/samza/util/TestExponentialThreadSleepStrategy.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/17875/diff/ > > > Testing > ------- > > Some > > > Thanks, > > Steven Yates > >
