Thanks Jakob allow me to correct and merge master into my branch etc -S
-------- Original message -------- From: Jakob Homan <[email protected]> Date: To: samza <[email protected]>,Jakob Homan <[email protected]>,Steven Yates <[email protected]> Subject: Re: Review Request 17875: SAMZA-30 This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17875/ samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala (Diff revision 2) 34 import org.apache.samza.util.ThreadNamePrefix.SAMZA_THREAD_NAME_PREFIX 34 import org.apache.samza.util.ExponentialThreadSleepStrategy Looks like we're still losing SAMZA096 with this patch. Make sure you've merged in the latest changes from trunk. samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala (Diff revision 2) 248 thread.setName(SAMZA_THREAD_NAME_PREFIX+BrokerProxy.BROKER_PROXY_THREAD_NAME_PREFIX) Part of the thread renaming loss samza-kafka/src/main/scala/org/apache/samza/util/ExponentialThreadSleepStrategy.scala (Diff revision 2) 1 package org.apache.samza.util; Need ASF file header samza-kafka/src/main/scala/org/apache/samza/util/ExponentialThreadSleepStrategy.scala (Diff revision 2) 7 var SLEEP_BACK_OFF_MULTIPLIER = 2.0 These can be vals since they are constants. samza-kafka/src/main/scala/org/apache/samza/util/ExponentialThreadSleepStrategy.scala (Diff revision 2) 19 val sleepMSBackOffDelay = ExponentialThreadSleepStrategy.SLEEP_INITIAL_BACK_OFF_DELAY_MS in the class, import ExpotentialThreadSleepStrategy._ and we can avoid all the extra qualification, to aid in readability. samza-kafka/src/main/scala/org/apache/samza/util/ExponentialThreadSleepStrategy.scala (Diff revision 2) 29 def getNextRedeliveryDelay(previousDelay: Long) = { Since the class has been broken out and can be used for more than just redelivery delays, can we make this a more generic name to ease re-use? samza-kafka/src/test/scala/org/apache/samza/util/TestExponentialThreadSleepStrategy.scala (Diff revision 2) 1 import grizzled.slf4j.Logging Need ASF file header samza-kafka/src/test/scala/org/apache/samza/util/TestExponentialThreadSleepStrategy.scala (Diff revision 2) 6 class TestExponentialThreadSleepStrategy extends Logging { Not logging so don't need to extend. samza-kafka/src/test/scala/org/apache/samza/util/TestExponentialThreadSleepStrategy.scala (Diff revision 2) 23 assertEquals(nextDelay, 400l) Can we extend the test to make sure we don't go past the maximum allowed? ie, we never go above 10000 ms? - Jakob Homan On February 11th, 2014, 7:33 p.m. PST, Steven Yates wrote: Review request for samza. By Steven Yates. Updated Feb. 11, 2014, 7:33 p.m. Repository: samza Description SAMZA-30 - Back off in BrokerProxy when fetch fails Testing Some Diffs samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala (95a1fb5) samza-kafka/src/main/scala/org/apache/samza/util/ExponentialThreadSleepStrategy.scala (PRE-CREATION) samza-kafka/src/test/scala/org/apache/samza/util/TestExponentialThreadSleepStrategy.scala (PRE-CREATION) View Diff
