----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17875/#review35129 -----------------------------------------------------------
Looks good except for my being unclear on the class name versus method name, mentioned below. Sorry for the delay. - Jakob Homan On Feb. 15, 2014, 4:06 a.m., Steven Yates wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17875/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2014, 4:06 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > SAMZA-30 - Back off in BrokerProxy when fetch fails > > > Diffs > ----- > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala > 34727e9 > samza-kafka/src/main/scala/org/apache/samza/util/ThreadUtil.scala > PRE-CREATION > samza-kafka/src/test/scala/org/apache/samza/util/TestThreadUtil.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/17875/diff/ > > > Testing > ------- > > Some > > > File Attachments > ---------------- > > SAMZA-30-4.diff > > https://reviews.apache.org/media/uploaded/files/2014/02/15/d4695ce4-f96c-47ab-aadb-5f3460f398d4__SAMZA-30-4.diff > SAMZA-30-3.diff > > https://reviews.apache.org/media/uploaded/files/2014/02/15/f158e7d4-577c-4bae-9ffc-9d982b4411e0__SAMZA-30-3.diff > > > Thanks, > > Steven Yates > >
