> On Feb. 13, 2014, 8:31 p.m., Jakob Homan wrote: > > samza-kafka/src/main/scala/org/apache/samza/util/ExponentialThreadSleepStrategy.scala, > > line 19 > > <https://reviews.apache.org/r/17875/diff/2/?file=483236#file483236line19> > > > > in the class, import ExpotentialThreadSleepStrategy._ and we can avoid > > all the extra qualification, to aid in readability.
Fixed in patch SAMZA-30-4.diff > On Feb. 13, 2014, 8:31 p.m., Jakob Homan wrote: > > samza-kafka/src/main/scala/org/apache/samza/util/ExponentialThreadSleepStrategy.scala, > > line 29 > > <https://reviews.apache.org/r/17875/diff/2/?file=483236#file483236line29> > > > > Since the class has been broken out and can be used for more than just > > redelivery delays, can we make this a more generic name to ease re-use? Renamed to ThreadUtil > On Feb. 13, 2014, 8:31 p.m., Jakob Homan wrote: > > samza-kafka/src/test/scala/org/apache/samza/util/TestExponentialThreadSleepStrategy.scala, > > line 23 > > <https://reviews.apache.org/r/17875/diff/2/?file=483237#file483237line23> > > > > Can we extend the test to make sure we don't go past the maximum > > allowed? ie, we never go above 10000 ms? We have captured this in testGetNextRedeliveryDelayCorrectlyReturnsMaximumDelayWhenDelayCapReached(). Let me know your thoughts > On Feb. 13, 2014, 8:31 p.m., Jakob Homan wrote: > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala, > > line 252 > > <https://reviews.apache.org/r/17875/diff/2/?file=483235#file483235line252> > > > > Part of the thread renaming loss Apologies updated local master and merged fixed this - Steven ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17875/#review34384 ----------------------------------------------------------- On Feb. 12, 2014, 3:33 a.m., Steven Yates wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17875/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2014, 3:33 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > SAMZA-30 - Back off in BrokerProxy when fetch fails > > > Diffs > ----- > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala > 95a1fb5 > > samza-kafka/src/main/scala/org/apache/samza/util/ExponentialThreadSleepStrategy.scala > PRE-CREATION > > samza-kafka/src/test/scala/org/apache/samza/util/TestExponentialThreadSleepStrategy.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/17875/diff/ > > > Testing > ------- > > Some > > > Thanks, > > Steven Yates > >
