seanjmullan commented on code in PR #234:
URL:
https://github.com/apache/santuario-xml-security-java/pull/234#discussion_r1410793725
##########
src/main/java/org/apache/xml/security/encryption/AgreementMethod.java:
##########
@@ -88,6 +91,22 @@ public interface AgreementMethod {
*/
void setKANonce(byte[] kanonce);
+
+ /**
+ * Returns KeyDerivationMethod information used in the
<code>AgreementMethod</code>.
+ * @return The KeyDerivationMethod information regarding the
<code>AgreementMethod</code>.
+ */
+ KeyDerivationMethod getKeyDerivationMethod() throws XMLSecurityException;
Review Comment:
By adding new methods to an interface, and modifying existing one, this
means applications must use the version of this API in which the methods are
added/modified (they can't expect to use older versions w/o the methods). I
guess that's ok, but not sure what our policy is on that - does this suggest we
need a new major version when this is released, @coheigea ?
##########
src/main/java/org/apache/xml/security/encryption/AgreementMethod.java:
##########
@@ -88,6 +91,22 @@ public interface AgreementMethod {
*/
void setKANonce(byte[] kanonce);
+
+ /**
+ * Returns KeyDerivationMethod information used in the
<code>AgreementMethod</code>.
+ * @return The KeyDerivationMethod information regarding the
<code>AgreementMethod</code>.
+ */
+ KeyDerivationMethod getKeyDerivationMethod() throws XMLSecurityException;
Review Comment:
By adding new methods to an interface, and modifying existing ones, this
means applications must use the version of this API in which the methods are
added/modified (they can't expect to use older versions w/o the methods). I
guess that's ok, but not sure what our policy is on that - does this suggest we
need a new major version when this is released, @coheigea ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@santuario.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
