seanjmullan commented on code in PR #234:
URL:
https://github.com/apache/santuario-xml-security-java/pull/234#discussion_r1411251273
##########
src/main/java/org/apache/xml/security/keys/KeyInfo.java:
##########
@@ -361,6 +362,23 @@ public void add(DEREncodedKeyValue derEncodedKeyValue) {
addReturnToSelf();
}
+ /**
+ * Method add AgreementMethod to the KeyInfo
+ *
+ * @param agreementMethod the AgreementMethod to be added. The
AgreementMethod must extend
+ * class {@link
org.apache.xml.security.utils.ElementProxy}
+ */
+ public void add(AgreementMethod agreementMethod) {
Review Comment:
Similar comment as my other one. I really think we should try to avoid
mixing xml encryption dependencies into this API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
