jrihtarsic commented on code in PR #234:
URL:
https://github.com/apache/santuario-xml-security-java/pull/234#discussion_r1412070804
##########
src/main/java/org/apache/xml/security/keys/KeyInfo.java:
##########
@@ -361,6 +362,23 @@ public void add(DEREncodedKeyValue derEncodedKeyValue) {
addReturnToSelf();
}
+ /**
+ * Method add AgreementMethod to the KeyInfo
+ *
+ * @param agreementMethod the AgreementMethod to be added. The
AgreementMethod must extend
+ * class {@link
org.apache.xml.security.utils.ElementProxy}
+ */
+ public void add(AgreementMethod agreementMethod) {
Review Comment:
I moved the newly added "AgreementMethod methods" to "KeyInfoEncExtension".
Please note that KeyInfo still has "encryption dependencies" due to
EncryptionKey. To fully decouple KeyInfo from encryption package we should
move all methods using EncryptionKey to the KeyInfoEncExtension. Should I move
methods for that class as well or this is to big change and might break some
implementations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@santuario.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
