coheigea commented on code in PR #234: URL: https://github.com/apache/santuario-xml-security-java/pull/234#discussion_r1410834465
########## src/main/java/org/apache/xml/security/encryption/AgreementMethod.java: ########## @@ -88,6 +91,22 @@ public interface AgreementMethod { */ void setKANonce(byte[] kanonce); + + /** + * Returns KeyDerivationMethod information used in the <code>AgreementMethod</code>. + * @return The KeyDerivationMethod information regarding the <code>AgreementMethod</code>. + */ + KeyDerivationMethod getKeyDerivationMethod() throws XMLSecurityException; Review Comment: I am OK with it as I doubt anyone is using it. Maybe we restrict this change to 4.0.x though and create a new 3.1.0 for Java 8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@santuario.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org