----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34079/#review127320 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 58) <https://reviews.apache.org/r/34079/#comment190585> it's better not using * in import. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 880) <https://reviews.apache.org/r/34079/#comment190587> For the user name, should it be case insensitive like role name? if yes, related test cases should be added. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 911) <https://reviews.apache.org/r/34079/#comment190588> The following code is duplicated many times, it's better to be wrapped in a method. Query query = pm.newQuery(MSentryUser.class); query.setFilter("this.userName == t"); query.declareParameters("java.lang.String t"); query.setUnique(true); - Ma JUNJIE On April 6, 2016, 5:14 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34079/ > ----------------------------------------------------------- > > (Updated April 6, 2016, 5:14 a.m.) > > > Review request for sentry, Dapeng Sun, shen guoquan, and Prasad Mujumdar. > > > Repository: sentry > > > Description > ------- > > Update jdo model for grant user to role > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java > 24514ea > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > d8f69b5 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > dbb5d8e > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 02f98e2 > > Diff: https://reviews.apache.org/r/34079/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
