> On 四月 7, 2016, 3:44 a.m., Jerry Chen wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java, > > line 1497 > > <https://reviews.apache.org/r/34079/diff/3/?file=1327638#file1327638line1497> > > > > Suggest to pass null instead of Sets.newHashSet(""). The same to next 3 > > instances.
Hi Jerry. Thank you for catching it, here should be the user set of requestor. I fixed it. - Colin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34079/#review127543 ----------------------------------------------------------- On 四月 8, 2016, 3:13 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34079/ > ----------------------------------------------------------- > > (Updated 四月 8, 2016, 3:13 a.m.) > > > Review request for sentry, Dapeng Sun and Jerry Chen. > > > Repository: sentry > > > Description > ------- > > Update jdo model for grant user to role > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java > 24514ea > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > d8f69b5 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > dbb5d8e > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 02f98e2 > > Diff: https://reviews.apache.org/r/34079/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
