> On 四月 1, 2016, 2:03 a.m., Jerry Chen wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 1325 > > <https://reviews.apache.org/r/34079/diff/1/?file=956186#file956186line1325> > > > > Shall we move the line "result = convertToTSentryRoles(mSentryRoles);" > > to the of after comitTransaction(pm)?
Hi Jerry, we may can't move it, the convertToTSentryRole() called `MSentryRole#getGroups()` which is lazy-loading, it should be call before transaction. committed. - Colin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34079/#review126284 ----------------------------------------------------------- On 四月 8, 2016, 3:13 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34079/ > ----------------------------------------------------------- > > (Updated 四月 8, 2016, 3:13 a.m.) > > > Review request for sentry, Dapeng Sun and Jerry Chen. > > > Repository: sentry > > > Description > ------- > > Update jdo model for grant user to role > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java > 24514ea > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > d8f69b5 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > dbb5d8e > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 02f98e2 > > Diff: https://reviews.apache.org/r/34079/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
