----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34079/#review127543 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 1381) <https://reviews.apache.org/r/34079/#comment190890> Suggest to early return for groups == null. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 1398) <https://reviews.apache.org/r/34079/#comment190891> Suggest to early return for users == null. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 1438) <https://reviews.apache.org/r/34079/#comment190893> It would better put getRoleNamesForGroups and getRoleNamesForUsers in the same persistent manager transcation. So we need to refactor getRoleNamesForGroups and getRoleNamesForUsers accepting a shared PersistenceManager similar to getRolesForUsers. sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java (line 1480) <https://reviews.apache.org/r/34079/#comment190894> Suggest to pass null instead of Sets.newHashSet(""). The same to next 3 instances. sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java (line 2016) <https://reviews.apache.org/r/34079/#comment190895> Suggest to pass null instead of new HashSet<String>(). The same for the next instance. - Jerry Chen On April 6, 2016, 2:46 p.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34079/ > ----------------------------------------------------------- > > (Updated April 6, 2016, 2:46 p.m.) > > > Review request for sentry, Dapeng Sun and Jerry Chen. > > > Repository: sentry > > > Description > ------- > > Update jdo model for grant user to role > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java > 24514ea > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > d8f69b5 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > dbb5d8e > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 02f98e2 > > Diff: https://reviews.apache.org/r/34079/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
