-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53920/#review156683
-----------------------------------------------------------




sentry-service/sentry-service-common/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java
 
<https://reviews.apache.org/r/53920/#comment226900>

    Could you explain a bit what is autoCreateAll do? And why should we remove 
it in this case? The default would be false?



sentry-service/sentry-service-common/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java
 
<https://reviews.apache.org/r/53920/#comment226901>

    Why do we need datanucleus cache l2 here?


- Hao Hao


On Nov. 19, 2016, 1:45 a.m., Alexander Kolbasov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53920/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2016, 1:45 a.m.)
> 
> 
> Review request for sentry, Colm O hEigeartaigh, Colin Ma, Hao Hao, Sravya 
> Tirukkovalur, and Vadim Spector.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> SENTRY-1534: Oracle supports serializable instead of repeatable-read
> 
> 
> Diffs
> -----
> 
>   
> sentry-service/sentry-service-common/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java
>  ec47909ab3098a890019bc19179786a2c5d7d87c 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
>  742798dca6b3ad8c9b9eee1eea5380001d1d0cd9 
> 
> Diff: https://reviews.apache.org/r/53920/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Kolbasov
> 
>

Reply via email to