> On Nov. 23, 2016, 1:38 a.m., Hao Hao wrote: > > sentry-service/sentry-service-common/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java, > > line 149 > > <https://reviews.apache.org/r/53920/diff/1/?file=1567316#file1567316line149> > > > > Could you explain a bit what is autoCreateAll do? And why should we > > remove it in this case? The default would be false? > > Alexander Kolbasov wrote: > When sentry starts it loggs: > > Property datanucleus.schema.autoCreateAll unknown - will be ignored > datanucleus.schema.autoCreateAll > > so our version of datanucleus doesn't understand it. > > That said it is a valid property according to the current docs, so we may > as well keep it. I'll revert this change.
>From the docs, it does look like a valid one. Is it because the particular >version we use does not support it? If so, we may want to replace it with the >corresponding property in the version we are using? - Hao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53920/#review156683 ----------------------------------------------------------- On Nov. 19, 2016, 1:45 a.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53920/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2016, 1:45 a.m.) > > > Review request for sentry, Colm O hEigeartaigh, Colin Ma, Hao Hao, Sravya > Tirukkovalur, and Vadim Spector. > > > Repository: sentry > > > Description > ------- > > SENTRY-1534: Oracle supports serializable instead of repeatable-read > > > Diffs > ----- > > > sentry-service/sentry-service-common/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > ec47909ab3098a890019bc19179786a2c5d7d87c > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 742798dca6b3ad8c9b9eee1eea5380001d1d0cd9 > > Diff: https://reviews.apache.org/r/53920/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
