> On April 14, 2017, 7:04 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 221 (patched) > > <https://reviews.apache.org/r/58221/diff/10/?file=1692735#file1692735line249> > > > > SentryStore cleaner need not be restarted every time sentry service is > > stoped and started. > > Na Li wrote: > in normal operation, stop() is the last call to clean up the resources. > And we need to stop SentryStore cleaner.
Normally we don't know whether this is the stop() happening because we are exiting or this is a test. During exit we do need to shut down the executor service. There is no harm in restarting the service for tests. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review172013 ----------------------------------------------------------- On April 19, 2017, 2:23 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58221/ > ----------------------------------------------------------- > > (Updated April 19, 2017, 2:23 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > SENTRY-1649 move HMS follower to runServer > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 16676fb > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 132db63 > > > Diff: https://reviews.apache.org/r/58221/diff/17/ > > > Testing > ------- > > > Thanks, > > Na Li > >
