> On April 14, 2017, 7:04 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Line 375 (original), 474 (patched) > > <https://reviews.apache.org/r/58221/diff/10/?file=1692735#file1692735line503> > > > > SentryStore cleaner need not be restarted every time sentry service is > > stoped and started. > > Na Li wrote: > Since we have to stop SentryStore cleaner at stop(). When test calls > start() after stop(), we have to start it in start(). Otherwise, it won't > work, and will cause test failure.
arguments from Sasha for why shutdown the executors at stop() "[1:19 AM] Alexander Kolbasov: In normal (non-test) situation stop() method is called during regular shutdown - e.g. when ^C is pressed (SIGINT is received by the process). As this happens we need to shutdown executors. This is the regular use case. Test use case is probably different, but I wouldn't worry too much about performance for creating/destroying executors for tests. Since in the normal use case we do need to shutdown the executor and executor shutdown is a well-defined operation, I think it is cleaner to use it rather then rely on just stopping the service or doing something complicated with Future.cancel(). - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review172013 ----------------------------------------------------------- On April 19, 2017, 2:23 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58221/ > ----------------------------------------------------------- > > (Updated April 19, 2017, 2:23 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > SENTRY-1649 move HMS follower to runServer > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 16676fb > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 132db63 > > > Diff: https://reviews.apache.org/r/58221/diff/17/ > > > Testing > ------- > > > Thanks, > > Na Li > >
