> On April 14, 2017, 7:04 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 222 (patched) > > <https://reviews.apache.org/r/58221/diff/10/?file=1692735#file1692735line250> > > > > I feel we should start call startHMSFollower at the end of runServer > > function. If there are no issues in starting the sentry service, we can > > start HMSFolloeer at the end. > > Na Li wrote: > The original code to start HMSFollower is in constructor. When I move it > to runServer(), putting it at the beginning is the closest approach to the > original in terms of the ordering. I am not familar with the system, and > moving it to the end of runServer() may cause some unknown problems. > > Na Li wrote: > I will move it to the end of runServer() > > Na Li wrote: > there is regression and test > org.apache.sentry.tests.e2e.metastore.TestDbNotificationListenerSentryDeserializer.testAlterPartition > failed after moving the function to the end of runServer(). So I move it > back to the beginning of runServer().
Why do you think that it is better to start HMSFollower in the end? - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review172013 ----------------------------------------------------------- On April 19, 2017, 2:23 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58221/ > ----------------------------------------------------------- > > (Updated April 19, 2017, 2:23 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > SENTRY-1649 move HMS follower to runServer > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 16676fb > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 132db63 > > > Diff: https://reviews.apache.org/r/58221/diff/17/ > > > Testing > ------- > > > Thanks, > > Na Li > >
