On 7/29/06, Wendy Smoak <[EMAIL PROTECTED]> wrote:
On 7/29/06, Sean Schofield <[EMAIL PROTECTED]> wrote: > Hibernate transactions requires JTA. I'm not sure what the license on > that is but I know the artifact is not available through Maven. It > would seem that there is also a problem with Facelets which is CDDL. > > One option is to make the petstore a java.net project. I'm not crazy > about shipping a WAR that is missing a key dependency. The other > option is to not ship the WAR at all and just provide very detailed > instructions on how to build the app using maven. I agree, for the people who don't read the instructions, the perception will be that the example app is "broken". I was also going to suggest just shipping this one as source. We will have to exclude the the incompatibly licensed dependencies from the default build, which means 'mvn install' would still build a war that doesn't work. (Back to that 'reading the directions' thing again. :) ). But 'mvn install -Phibernate' would.
That seems like a pretty reasonable approach ... that way, our existing approach to assembly on apps wouldn't have to change. (Just a thought... have a context listener check for the required
dependencies and set a flag, then have a Filter check for the flag and and display a page of instructions if anything is missing. Something along the lines of the 'Happy Axis' page. Would that work?)
That would be a good idea regardless of the particulars of this particular app ... and ties in to some "help the developer get it right" ideas that I had about static analysis of the webapp. See SHALE-196 as a place to accumulate ideas for stuff like this.
I'm almost ready to show the initial checkin but I have a few issues > with Hibernate and lazy collections. If anybody has experience with > Hibernate and wants to help, that would be great. James, probably. But if it's mostly working, go ahead and check it in and start another thread about the problem. I'm at NFJS this weekend, and 'Advanced Hibernate' is this afternoon. Maybe I can work it in as a question. :) -- Wendy
Craig
