http://codereview.appspot.com/4148044/diff/14001/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizerTest.java File java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizerTest.java (right):
http://codereview.appspot.com/4148044/diff/14001/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizerTest.java#newcode86 java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizerTest.java:86: public void testLargeJPEGWithEtag() throws Exception { might as well club both tests into 1. http://codereview.appspot.com/4148044/diff/14001/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizerTest.java#newcode101 java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizerTest.java:101: responseBuilder.addHeader(CACHE_CONTROL_HEADER_NAME, CACHE_CONTROL_HEADER_VALUE); replace vars with the values, since they are not getting used anywhere else, and it would also make the code more readable: responseBuilder.addHeader("Cache-Control", "public, max-age=86400"); http://codereview.appspot.com/4148044/
