http://codereview.appspot.com/4148044/diff/14001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java
(right):
http://codereview.appspot.com/4148044/diff/14001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java#newcode146
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java:146:
.setResponse(minBytes);
On 2011/02/10 20:54:57, johnfargo wrote:
let's remove the ETAG header within HttpResponse(Builder) itself on
write ie. in
the setResponse() method, since that is the actual operation that
changes it.
Done.
http://codereview.appspot.com/4148044/diff/14001/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizerTest.java
File
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizerTest.java
(right):
http://codereview.appspot.com/4148044/diff/14001/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizerTest.java#newcode86
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizerTest.java:86:
public void testLargeJPEGWithEtag() throws Exception {
On 2011/02/10 18:44:45, gagan.goku wrote:
might as well club both tests into 1.
Done.
http://codereview.appspot.com/4148044/diff/14001/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizerTest.java#newcode101
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizerTest.java:101:
responseBuilder.addHeader(CACHE_CONTROL_HEADER_NAME,
CACHE_CONTROL_HEADER_VALUE);
On 2011/02/10 18:44:45, gagan.goku wrote:
replace vars with the values, since they are not getting used anywhere
else, and
it would also make the code more readable:
responseBuilder.addHeader("Cache-Control", "public, max-age=86400");
Done.
http://codereview.appspot.com/4148044/
