http://codereview.appspot.com/4148044/diff/24002/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java (right):
http://codereview.appspot.com/4148044/diff/24002/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java#newcode100 java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java:100: removeHeader("ETag"); This approach seems kind of messy because one would not expect a method called setResponseString to modify the response headers really. Plus its easy to do things like: new HttpResponseBuilder() .addHeader( compuedEtag ) .setResponseString("blah") .create() and we would actually clear the etag header in that case. If you want to do this, mention this quirk in the class comment and this methods comment so ppl can be vary of this. http://codereview.appspot.com/4148044/diff/24002/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java#newcode145 java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java:145: removeHeader("ETag"); same here http://codereview.appspot.com/4148044/diff/24002/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java#newcode157 java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java:157: removeHeader("ETag"); same here http://codereview.appspot.com/4148044/
