Re: Bug Fix: Cache headers are removed by BaseOptimizer for all rewritten images. (issue4148044)

[satya3656]

http://codereview.appspot.com/4148044/diff/24002/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java
(right):

http://codereview.appspot.com/4148044/diff/24002/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java#newcode100
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java:100:
removeHeader("ETag");
Removing this piece as it might add breakages to the functionality of
existing code who does
new HttpResponseBuilder()
  .addHeader( compuedEtag )
  .setResponseString("blah")
  .create()

http://codereview.appspot.com/4148044/diff/24002/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java#newcode145
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java:145:
removeHeader("ETag");
On 2011/02/14 10:35:20, gagan.goku wrote:

same here

Removed

http://codereview.appspot.com/4148044/diff/24002/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java#newcode157
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java:157:
removeHeader("ETag");
On 2011/02/14 10:35:20, gagan.goku wrote:

same here

removed

http://codereview.appspot.com/4148044/