I'm here to verify the sanity of Dan's build env. :) I was able to successfully build this against the Trunk as well.
Thanks, -Stanton From: Dan Dumont/Westford/IBM@Lotus To: "shindig" <dev@shindig.apache.org>, Dan Dumont/Westford/IBM@Lotus, "Paul Lindner" <lind...@inuus.com>, Date: 08/08/2011 14:53 Subject: Re: Review Request: Enable closure compiler by default > On 2011-08-08 18:38:40, Paul Lindner wrote: > > still failing for me.. > > > > Looks like the shindig and opensocial vars are not coming as part of the js payload. > > > > perhaps closure is stripping that out? > > Not sure... shindig.closure.compile.level=simple That should be setting it to simple optimizations. Advanced will fail, but shindig is a global and is exported, so simple should definitely NOT be obliterating them. I'll get someone else here to try compiling with my patch to verify the sanity of my build env. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1179/#review1322 ----------------------------------------------------------- On 2011-07-26 14:11:17, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1179/ > ----------------------------------------------------------- > > (Updated 2011-07-26 14:11:17) > > > Review request for shindig. > > > Summary > ------- > > Enable closure with simple optimizations turned on. > > > Diffs > ----- > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/js/CompilationProcessorTest.java 1150920 > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensearch/opensearch.js 1150288 > http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1150920 > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/JsCompileMode.java 1150920 > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/CompilationProcessor.java 1150920 > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/js/JsCompilerModule.java 1150920 > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java 1150920 > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/globals/globals.js 1150920 > > Diff: https://reviews.apache.org/r/1179/diff > > > Testing > ------- > > Existing js tests pass > > > Thanks, > > Dan > >
