-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1179/#review1327
-----------------------------------------------------------


Still seeing this with latest patch...  weird:

Tests run: 30, Failures: 0, Errors: 1, Skipped: 7, Time elapsed: 26.754 sec <<< 
FAILURE!
fetchPerson(org.apache.shindig.server.endtoend.EndToEndTest)  Time elapsed: 
0.007 sec  <<< ERROR!
======= EXCEPTION START ========
EcmaError: lineNumber=[35] column=[0] lineSource=[<no source>] 
name=[ReferenceError] 
sourceName=[http://localhost:9003/gadgets/js/content-rewrite:views:core:opensocial-0.9!core:rpc.js?container=default&nocache=0&debug=0&c=0&v=85318482772cf354d729d95935a8412a&jsload=0]
 message=[ReferenceError: "gadgets" is not defined. 
(http://localhost:9003/gadgets/js/content-rewrite:views:core:opensocial-0.9!core:rpc.js?container=default&nocache=0&debug=0&c=0&v=85318482772cf354d729d95935a8412a&jsload=0#35)]
com.gargoylesoftware.htmlunit.ScriptException: ReferenceError: "gadgets" is not 
defined. 
(http://localhost:9003/gadgets/js/content-rewrite:views:core:opensocial-0.9!core:rpc.js?container=default&nocache=0&debug=0&c=0&v=85318482772cf354d729d95935a8412a&jsload=0#35)
        at 
com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine$HtmlUnitContextAction.run(JavaScriptEngine.java:601)
        at 
net.sourceforge.htmlunit.corejs.javascript.Context.call(Context.java:537)
        at 
net.sourceforge.htmlunit.corejs.javascript.ContextFactory.call(ContextFactory.java:538)
        at 
com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine.execute(JavaScriptEngine.java:499)
        at 
com.gargoylesoftware.htmlunit.html.HtmlPage.loadExternalJavaScriptFile(HtmlPage.java:970)
        at 
com.gargoylesoftware.htmlunit.html.HtmlScript.executeScriptIfNeeded(HtmlScript.java:363)


- Paul


On 2011-08-08 19:53:10, Dan Dumont wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1179/
> -----------------------------------------------------------
> 
> (Updated 2011-08-08 19:53:10)
> 
> 
> Review request for shindig.
> 
> 
> Summary
> -------
> 
> Enable closure with simple optimizations turned on.
> 
> 
> Diffs
> -----
> 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/globals/globals.js
>  1154968 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensearch/opensearch.js
>  1154968 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties
>  1154968 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/JsCompileMode.java
>  1154968 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/CompilationProcessor.java
>  1154968 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/js/JsCompilerModule.java
>  1154968 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java
>  1154968 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/js/CompilationProcessorTest.java
>  1154968 
> 
> Diff: https://reviews.apache.org/r/1179/diff
> 
> 
> Testing
> -------
> 
> Existing js tests pass
> 
> 
> Thanks,
> 
> Dan
> 
>

Reply via email to