----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1179/ -----------------------------------------------------------
(Updated 2011-08-12 19:02:33.931983) Review request for shindig. Changes ------- Paul, I think we nailed the test failures (great find, Stanton!). Can you give it another try with this patch? Summary ------- Enable closure with simple optimizations turned on. Diffs (updated) ----- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/globals/globals.js 1157183 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensearch/opensearch.js 1157183 http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1157183 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/JsCompileMode.java 1157183 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/CompilationProcessor.java 1157183 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/js/JsCompilerModule.java 1157183 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java 1157183 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/js/CompilationProcessorTest.java 1157183 http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java 1157183 Diff: https://reviews.apache.org/r/1179/diff Testing ------- Existing js tests pass Thanks, Dan
