rombert commented on a change in pull request #19:
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/19#discussion_r600332843
##########
File path: src/main/java/org/apache/sling/dynamicinclude/Configuration.java
##########
@@ -66,11 +65,7 @@
@AttributeDefinition(name="Resource types", description="Filter will
replace components with selected resource types", cardinality =
Integer.MAX_VALUE)
String include$_$filter_config_resource$_$types() default "";
- @AttributeDefinition(name = "Include type", description = "Type of
generated include tags", options = {
- @Option(label = "Apache SSI", value = "SSI"),
- @Option(label = "ESI", value = "ESI"),
- @Option(label = "Javascript", value = "JSI")
- })
+ @AttributeDefinition(name = "Include type", description = "Type of
generated include tags")
Review comment:
Any reason for removing this?
##########
File path:
src/main/java/org/apache/sling/dynamicinclude/api/IncludeGenerator.java
##########
@@ -17,13 +17,15 @@
* under the License.
*/
-package org.apache.sling.dynamicinclude.generator;
+package org.apache.sling.dynamicinclude.api;
+
+import org.apache.sling.api.SlingHttpServletRequest;
/**
* Include generator interface
*/
public interface IncludeGenerator {
String getType();
- String getInclude(String url);
+ String getInclude(SlingHttpServletRequest request,String url);
Review comment:
I think it's confusing to pass in the request and a string named `url` I
see that the `url` parameter is based on the sling request, so maybe we can
have a different approach here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
