rombert commented on a change in pull request #19:
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/19#discussion_r605601669
##########
File path:
src/main/java/org/apache/sling/dynamicinclude/api/IncludeGenerator.java
##########
@@ -17,13 +17,15 @@
* under the License.
*/
-package org.apache.sling.dynamicinclude.generator;
+package org.apache.sling.dynamicinclude.api;
+
+import org.apache.sling.api.SlingHttpServletRequest;
/**
* Include generator interface
*/
public interface IncludeGenerator {
String getType();
- String getInclude(String url);
+ String getInclude(SlingHttpServletRequest request,String url);
Review comment:
I think that would be ok, granted that we:
- find a better name for it ( normalizedUrl?)
- add better documentation to the interface and the method, explaining why
we pass in an apparently redundant parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
