santiagozky commented on a change in pull request #19:
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/19#discussion_r601510841
##########
File path: src/main/java/org/apache/sling/dynamicinclude/Configuration.java
##########
@@ -66,11 +65,7 @@
@AttributeDefinition(name="Resource types", description="Filter will
replace components with selected resource types", cardinality =
Integer.MAX_VALUE)
String include$_$filter_config_resource$_$types() default "";
- @AttributeDefinition(name = "Include type", description = "Type of
generated include tags", options = {
- @Option(label = "Apache SSI", value = "SSI"),
- @Option(label = "ESI", value = "ESI"),
- @Option(label = "Javascript", value = "JSI")
- })
+ @AttributeDefinition(name = "Include type", description = "Type of
generated include tags")
Review comment:
well, if the point is to allow extra implementations, that means we
cannot longer have a fixed list of options. otherwise you cannot choose
whatever you implement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
