santiagozky commented on a change in pull request #19:
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/19#discussion_r601516107
##########
File path:
src/main/java/org/apache/sling/dynamicinclude/api/IncludeGenerator.java
##########
@@ -17,13 +17,15 @@
* under the License.
*/
-package org.apache.sling.dynamicinclude.generator;
+package org.apache.sling.dynamicinclude.api;
+
+import org.apache.sling.api.SlingHttpServletRequest;
/**
* Include generator interface
*/
public interface IncludeGenerator {
String getType();
- String getInclude(String url);
+ String getInclude(SlingHttpServletRequest request,String url);
Review comment:
the issue here is that the url is not just taken from the request as it
is. It is previously checked to do things like removing the query part, map
it,encode, etc (in
https://github.com/apache/sling-org-apache-sling-dynamic-include/blob/master/src/main/java/org/apache/sling/dynamicinclude/IncludeTagFilter.java#L149),.
we could remove the url parameter, but that means any IncludeGenerator would
be responsible for doing that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
