enapps-enorman commented on code in PR #109:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/109#discussion_r1433092042
##########
src/test/java/org/apache/sling/resourceresolver/impl/mapping/InMemoryResourceProvider.java:
##########
@@ -105,7 +105,7 @@ public Iterator<Resource> findResources(@NotNull
ResolveContext<Void> ctx, Strin
// we don't explicitly filter paths under jcr:system, but we
don't expect to have such resources either
// and this stub provider is not the proper location to test
JCR queries
- if ( "sql".equals(language) && "SELECT sling:alias FROM
nt:base AS page WHERE (NOT ISDESCENDANTNODE(page,'/jcr:system')) AND
sling:alias IS NOT NULL".equals(query) ) {
+ if ( "JCR-SQL2".equals(language) && "SELECT [sling:alias]
FROM [nt:base] WHERE NOT isdescendantnode('/jcr:system') AND [sling:alias] IS
NOT NULL".equals(query) ) {
Review Comment:
I'd suggest using the Query.JCR_SQL2 constant here.
##########
src/test/java/org/apache/sling/resourceresolver/impl/mapping/MapEntriesTest.java:
##########
@@ -224,7 +224,7 @@ public void
test_that_duplicate_alias_doesnt_replace_first_alias() {
when(secondResult.getName()).thenReturn("child2");
when(secondResult.getValueMap()).thenReturn(buildValueMap(ResourceResolverImpl.PROP_ALIAS,
"alias"));
- when(resourceResolver.findResources(anyString(),
eq("sql"))).thenAnswer(new Answer<Iterator<Resource>>() {
+ when(resourceResolver.findResources(anyString(),
eq("JCR-SQL2"))).thenAnswer(new Answer<Iterator<Resource>>() {
Review Comment:
I'd suggest using the Query.JCR_SQL2 constant here.
##########
src/test/java/org/apache/sling/resourceresolver/impl/mapping/MapEntriesTest.java:
##########
@@ -187,7 +187,7 @@ public void test_simple_alias_support() {
when(result.getName()).thenReturn("child");
when(result.getValueMap()).thenReturn(buildValueMap(ResourceResolverImpl.PROP_ALIAS,
"alias"));
- when(resourceResolver.findResources(anyString(),
eq("sql"))).thenAnswer(new Answer<Iterator<Resource>>() {
+ when(resourceResolver.findResources(anyString(),
eq("JCR-SQL2"))).thenAnswer(new Answer<Iterator<Resource>>() {
Review Comment:
I'd suggest using the Query.JCR_SQL2 constant here.
##########
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##########
@@ -1154,7 +1152,7 @@ private Map<String, Map<String, Collection<String>>>
loadAliases(final ResourceR
log.debug("start alias query: {}", queryString);
long queryStart = System.nanoTime();
- final Iterator<Resource> i = resolver.findResources(queryString,
"sql");
+ final Iterator<Resource> i = resolver.findResources(queryString,
"JCR-SQL2");
Review Comment:
I'd suggest using the Query.JCR_SQL2 constant here instead.
[Query
JavaDocs](https://javadoc.io/static/javax.jcr/jcr/2.0/javax/jcr/query/Query.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
