enapps-enorman commented on code in PR #109:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/109#discussion_r1433717742
##########
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##########
@@ -1154,7 +1152,7 @@ private Map<String, Map<String, Collection<String>>>
loadAliases(final ResourceR
log.debug("start alias query: {}", queryString);
long queryStart = System.nanoTime();
- final Iterator<Resource> i = resolver.findResources(queryString,
"sql");
+ final Iterator<Resource> i = resolver.findResources(queryString,
"JCR-SQL2");
Review Comment:
Pretty weak that you just merging immediately without giving me a chance to
respond. You are already using a JCR specific language there so pretending
that a different backend would support that language somehow seems unlikely to
me. Using a string doesn't magically make it more portable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
