rombert commented on code in PR #109:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/109#discussion_r1434028256
##########
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##########
@@ -1154,7 +1152,7 @@ private Map<String, Map<String, Collection<String>>>
loadAliases(final ResourceR
log.debug("start alias query: {}", queryString);
long queryStart = System.nanoTime();
- final Iterator<Resource> i = resolver.findResources(queryString,
"sql");
+ final Iterator<Resource> i = resolver.findResources(queryString,
"JCR-SQL2");
Review Comment:
We already optionally import `javax.jcr`, so I don't see what the issue
would be with referencing the constant value.
https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/c7bdc4d6a5e360623b0ad3c117f1728e26c12e8e/bnd.bnd#L2
The java compiler will inline string references in the resulting class file
anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
