enapps-enorman commented on code in PR #109:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/109#discussion_r1434736024
##########
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##########
@@ -1154,7 +1152,7 @@ private Map<String, Map<String, Collection<String>>>
loadAliases(final ResourceR
log.debug("start alias query: {}", queryString);
long queryStart = System.nanoTime();
- final Iterator<Resource> i = resolver.findResources(queryString,
"sql");
+ final Iterator<Resource> i = resolver.findResources(queryString,
"JCR-SQL2");
Review Comment:
> The java compiler will inline string references in the resulting class
file anyway.
Yes, this is true. I prefer using the Query.JCR_SQL2 constant just in case
that language gets deprecated someday (like what happened for the "xpath" and
"sql" languages) so that your IDE will warn you about usage of deprecated code
in that scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
