Hi

Am 09.09.2013 um 11:45 schrieb Bertrand Delacretaz:

> On Fri, Sep 6, 2013 at 3:31 PM, Carsten Ziegeler <cziege...@apache.org> wrote:
>> ...The constants should really be defined in the BVP class, this is the
>> service declaring them...
> 
> Good point, done in revision 1521017

Hmm. While this makes sense, doesn't it introduce versioning problems ? 

You added a constant to the interface, so what will the export package version 
be ? and the compatibility consequences ? Is this interface @ConsumerType

Regards
Felix



> 
>> 
>> ... I don't understand what you mean by "changes to existing code" - this is
>> new, isn't it?...
> 
> Yes but existing code does use BindingsValuesProvider, and
> BindingsValuesProvidersByContext returning a Collection causes less
> changes to that existing code than the addContextBindings method that
> we discussed. I don't think one is better than the other anyway, it's
> just slightly different styles.
> 
> -Bertrand

Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to