On 21 October 2014 13:35, Bertrand Delacretaz <bdelacre...@apache.org> wrote: > Hi, > > On Tue, Oct 21, 2014 at 1:04 PM, Ian Boston <i...@tfd.co.uk> wrote: >> ...Yammer metrics went through some breaking API changes between 3.0 and >> 3.1. It wasnt designed for OSGi and it is debatable if those changes >> conform to an OSGi notion of semantic versioning... > >> ...One reason for the SPI is that Yammer Metrics uses >> sun.misc.Unsafe and does implements a 64bit Stripe class that bind to >> the Sun JDK. There are pointers to what needs to be done OpenJDK...
actually I think the pointer is commented out code to make it work in OpenJDK. > > Ok, given those two points I'm ok with not using Yammer Metrics - The SPI implementation should obviously live in its own bundle so that no one feels forced to use Yammer Metrics. > isn't there another choice besides building our own? 100s (probably). Its a bit like logging. Everyone writes their own initially, until they have to deal with real usage. A large proportion are unsupported, left to fester on GitHub. Some come from commercial organisations. Some are based on proprietary output protocols and some on standards. If you want to do a proper asesment of Yammer Metrics start at [1]. Its also worth looking at [2]. I haven found a list of libs in the past. I am sure we could do a simple implementation of the SPI for those that don't want to run Metrics.... but we don't need to as the proposal stands. It has a null impl built in. 1 https://dropwizard.github.io/metrics/3.1.0/about/ 2 http://pivotallabs.com/139-metrics-metrics-everywhere/ > >>> ...Also, as Ian says we need metrics all the way down to the Oak level,.. > >>.. Or putting this simple API somewhere it can be used by both projects ?.. > > Ok, if we create a simple OSGi-friendly metrics library that's shared > between Sling, Oak and maybe Felix (as those communities overlap) that > would be much better that just doing it in our own corner. Agreed, imho thats what Amit's proposal does, but it needs to be somewhere it can be used. If Oak and Felix dont want to use it, then Sling is the right place. Best Regards Ian > > -Bertrand
