Also, I guess I need to be careful to run spotless after I make changes to the tests per package.
> On May 27, 2022, at 10:58 AM, Eric Pugh <ep...@opensourceconnections.com> > wrote: > > Here is what I did the other night: > > https://github.com/apache/solr/compare/main...epugh:intellij_suggested_fixes > <https://github.com/apache/solr/compare/main...epugh:intellij_suggested_fixes> > > I could just work on package by package, pushing them up, and if there is > debate, I can just revert a commit on a package by package basis?? > > Thoughts? > > Eric > > >> On May 27, 2022, at 10:29 AM, Mike Drob <md...@mdrob.com >> <mailto:md...@mdrob.com>> wrote: >> >> I would try to handle them in several small PRs either grouped by module or >> by warning type. >> >> On Fri, May 27, 2022 at 9:24 AM Eric Pugh <ep...@opensourceconnections.com >> <mailto:ep...@opensourceconnections.com>> wrote: >> Hey all, was poking around at a unit test while watching TV and noticed lots >> of warnings from IntelliJ, little stuff like exceptions being thrown that >> don’t need to be thrown, unused variables, or typos. >> >> I was thinking about going through and fixing those, just to get the long >> list of problems down…. Is this best handled with a single PR with a JIRA >> issue? Say a JIRA issue like “Clean up IntelliJ warnings for Test Code”? >> >> Eric >> >> >> >> _______________________ >> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | >> http://www.opensourceconnections.com <http://www.opensourceconnections.com/> >> | My Free/Busy <http://tinyurl.com/eric-cal> >> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed >> <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw> >> >> This e-mail and all contents, including attachments, is considered to be >> Company Confidential unless explicitly stated otherwise, regardless of >> whether attachments are marked as such. >> > > _______________________ > Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | > http://www.opensourceconnections.com <http://www.opensourceconnections.com/> > | My Free/Busy <http://tinyurl.com/eric-cal> > Co-Author: Apache Solr Enterprise Search Server, 3rd Ed > <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw> > > This e-mail and all contents, including attachments, is considered to be > Company Confidential unless explicitly stated otherwise, regardless of > whether attachments are marked as such. > _______________________ Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | http://www.opensourceconnections.com <http://www.opensourceconnections.com/> | My Free/Busy <http://tinyurl.com/eric-cal> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw> This e-mail and all contents, including attachments, is considered to be Company Confidential unless explicitly stated otherwise, regardless of whether attachments are marked as such.
